Use janet-simple grammar for Janet #9247
Merged
+89
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
added
S-waiting-on-author
|
Does squashing to a single commit and force-pushing sound ok? |
archseer
reviewed
Jan 9, 2024
|
No need to manually squash, we'll squash when merging |
|
I don't understand this error: I guess the line in question is this one. I think I don't see any error via Any hints as to what I might be missing? |
|
You should see the same error printed to the log when opening a janet file. You need to run helix via |
|
Thanks for the hints. Looks like an extra section got added back here. I guess my bad for putting the new section elsewhere and removing the old one before the merge (^^; Sorry about that. |
the-mikedavis
approved these changes
Jan 11, 2024
|
(The CI failures are unrelated - it's caused by a sourcehut outage) |
the-mikedavis
added
S-waiting-on-review
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
* Use janet-simple grammar for Janet * Update book * Tweak language name and related * Rename janet-simple to janet in book * Remove spurious language section for janet * Drop quote_lit and qq_lit related highlighting --------- Co-authored-by: sogaiu <[email protected]> Co-authored-by: Blaž Hrastnik <[email protected]>
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
* Use janet-simple grammar for Janet * Update book * Tweak language name and related * Rename janet-simple to janet in book * Remove spurious language section for janet * Drop quote_lit and qq_lit related highlighting --------- Co-authored-by: sogaiu <[email protected]> Co-authored-by: Blaž Hrastnik <[email protected]>
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
* Use janet-simple grammar for Janet * Update book * Tweak language name and related * Rename janet-simple to janet in book * Remove spurious language section for janet * Drop quote_lit and qq_lit related highlighting --------- Co-authored-by: sogaiu <[email protected]> Co-authored-by: Blaž Hrastnik <[email protected]>
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
* Use janet-simple grammar for Janet * Update book * Tweak language name and related * Rename janet-simple to janet in book * Remove spurious language section for janet * Drop quote_lit and qq_lit related highlighting --------- Co-authored-by: sogaiu <[email protected]> Co-authored-by: Blaž Hrastnik <[email protected]>
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
* Use janet-simple grammar for Janet * Update book * Tweak language name and related * Rename janet-simple to janet in book * Remove spurious language section for janet * Drop quote_lit and qq_lit related highlighting --------- Co-authored-by: sogaiu <[email protected]> Co-authored-by: Blaž Hrastnik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on this comment, this PR is mostly about using the tree-sitter-janet-simple grammar for Janet support along with a syntax highligting query file.
It also adds some bits for
janet-format-- a formatter for Janet that comes with the spork library.I am aware of 2 grammars [1] for Janet and each took a slightly different approach from the other. The one that's part of this PR is used in nvim-treesitter, difftastic, and there is code to use it from Emacs as well.
Due to historical reasons, this one is named "tree-sitter-janet-simple" (internally
janet_simple-- to avoid name collisions) and IIUC that means the value fornameinlanguages.tomlneeds to bejanet-simple(under both[[language]]and[[grammar]]). Or, at least, that's what made it work for me. Please point out if that should be changed and if so how :)LSP support for Janet is still maturing and although I did get it to work with some degree of success, I didn't feel the time was right yet.
[1] Here is the other one for reference.